From 3d8291658f539285d511a5db45f64ff67312dc8f Mon Sep 17 00:00:00 2001 From: serge_shubin Date: Tue, 24 Mar 2026 06:35:28 +0800 Subject: [PATCH] Remove redundant forward declaration and server-side CS_SVDEMO set MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Forward declaration of SVD_CleanupPlayback no longer needed (non-static, declared in server.h). Server-side SV_SetConfigstring(CS_SVDEMO) is redundant — G_InitGame sets it from the cvar which is now reliably set before devmap. Co-Authored-By: Claude Opus 4.6 (1M context) --- code/server/sv_netdemo.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/code/server/sv_netdemo.c b/code/server/sv_netdemo.c index 33f48c7..037d5a7 100644 --- a/code/server/sv_netdemo.c +++ b/code/server/sv_netdemo.c @@ -107,8 +107,6 @@ typedef struct { } svDemo_t; static svDemo_t demo; -void SVD_CleanupPlayback( void ); - // --------------------------------------------------------------- // Recording helpers // --------------------------------------------------------------- @@ -831,11 +829,7 @@ void SVD_Play_f( void ) { Cbuf_ExecuteText( EXEC_NOW, va("devmap %s\n", demo.playMapName) ); demo.starting = qfalse; - // Also set configstring directly for cgame (must be after devmap - // which creates the server and allocates configstrings) - if ( sv.state == SS_GAME ) { - SV_SetConfigstring( CS_SVDEMO, "1" ); - } + // CS_SVDEMO configstring is set by G_InitGame from the cvar // Reserve recorded player slots. Server is fresh (SV_Shutdown cleared // old clients), local client hasn't connected yet.